Prevent cross-EP Cast fusion in RemoveDuplicateCastTransformer#27363
Merged
Prevent cross-EP Cast fusion in RemoveDuplicateCastTransformer#27363
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect Cast node fusion across execution provider (EP) boundaries in the RemoveDuplicateCastTransformer. The bug allowed consecutive Cast nodes assigned to different EPs to be fused, resulting in a node with an input type unsupported by its EP (e.g., Cast(int64->float, CPU) -> Cast(float->float16, WebGPU) being fused into Cast(int64->float16, WebGPU), which fails because WebGPU doesn't support int64 inputs).
Changes:
- Added EP boundary check in RemoveDuplicateCastTransformer to prevent cross-EP Cast fusion
- Added regression test verifying Cast nodes on different EPs are not fused
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| onnxruntime/core/optimizer/insert_cast_transformer.cc | Added cross-EP check before fusing Cast nodes, with detailed comments explaining the issue and solution |
| onnxruntime/test/framework/insert_cast_transformer_test.cc | Added regression test that creates CPU->WebGPU Cast chain and verifies they remain separate after transformation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guschmue
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an incorrect Cast deduplication across execution provider boundaries.
Today,
Cast(int64->float, CPU) -> Cast(float->float16, WebGPU)can be fused intoCast(int64->float16, WebGPU), which is invalid for WebGPU and can fail kernel lookup.This change adds an EP check so Cast fusion only happens when both nodes are on the same EP, and adds a regression test for this scenario.
Motivation and Context
Fixes #27291